Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update lightpush API for autosharding #774

Merged
merged 9 commits into from
Sep 29, 2023
Merged

feat: update lightpush API for autosharding #774

merged 9 commits into from
Sep 29, 2023

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Sep 26, 2023 •
edited
Loading

Description

Update lightPush API to take pubSub topic optionally and derive from contentTopic using autosharding logic.

Changes

  • Change lightpush API to make pubSubTopic optional
  • Autoshard specific light push tests

Tests

Ran all unit tests

@chaitanyaprem chaitanyaprem mentioned this pull request Sep 26, 2023
Closed
2 tasks
@status-im-auto
Copy link

status-im-auto commented Sep 26, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (42)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a305056 #1 2023-09-26 08:13:47 ~2 min nix-flake 📄log
✔️ a305056 #1 2023-09-26 08:14:11 ~2 min linux 📦deb
✔️ a305056 #1 2023-09-26 08:14:50 ~3 min tests 📄log
✔️ a305056 #1 2023-09-26 08:14:56 ~3 min tests 📄log
✔️ a305056 #1 2023-09-26 08:15:36 ~4 min android 📦tgz
✔️ a305056 #1 2023-09-26 08:16:15 ~4 min ios 📦tgz
✔️ b969b15 #2 2023-09-26 09:16:16 ~59 sec linux 📦deb
✔️ b969b15 #2 2023-09-26 09:17:19 ~2 min tests 📄log
✔️ b969b15 #2 2023-09-26 09:17:48 ~2 min nix-flake 📄log
✔️ b969b15 #2 2023-09-26 09:18:39 ~3 min tests 📄log
✔️ b969b15 #2 2023-09-26 09:19:04 ~3 min android 📦tgz
✔️ b969b15 #2 2023-09-26 09:19:47 ~4 min ios 📦tgz
✔️ 809b498 #3 2023-09-27 05:33:51 ~1 min linux 📦deb
✔️ 809b498 #3 2023-09-27 05:34:26 ~1 min tests 📄log
✔️ 809b498 #3 2023-09-27 05:34:41 ~1 min nix-flake 📄log
✔️ 809b498 #3 2023-09-27 05:34:52 ~2 min tests 📄log
✔️ 809b498 #3 2023-09-27 05:36:00 ~3 min android 📦tgz
✔️ 809b498 #3 2023-09-27 05:36:33 ~3 min ios 📦tgz
✔️ 4827020 #4 2023-09-27 06:51:43 ~1 min tests 📄log
✔️ 4827020 #4 2023-09-27 06:52:15 ~2 min nix-flake 📄log
✔️ 4827020 #4 2023-09-27 06:52:33 ~2 min linux 📦deb
✔️ 4827020 #4 2023-09-27 06:53:13 ~3 min tests 📄log
✔️ 4827020 #4 2023-09-27 06:53:16 ~3 min android 📦tgz
✔️ 4827020 #4 2023-09-27 06:53:50 ~3 min ios 📦tgz
✔️ 154287e #5 2023-09-28 23:07:50 ~1 min linux 📦deb
✔️ 154287e #5 2023-09-28 23:07:55 ~1 min tests 📄log
✔️ 154287e #5 2023-09-28 23:08:31 ~1 min nix-flake 📄log
✔️ 154287e #5 2023-09-28 23:09:42 ~2 min tests 📄log
✔️ 154287e #5 2023-09-28 23:09:58 ~3 min android 📦tgz
✔️ 154287e #5 2023-09-28 23:10:54 ~4 min ios 📦tgz
✔️ e95418d #6 2023-09-28 23:23:42 ~1 min linux 📦deb
✔️ e95418d #6 2023-09-28 23:24:14 ~1 min tests 📄log
✔️ e95418d #6 2023-09-28 23:24:30 ~1 min nix-flake 📄log
✔️ e95418d #7 2023-09-28 23:24:41 ~56 sec linux 📦deb
✔️ e95418d #7 2023-09-28 23:24:46 ~12 sec nix-flake 📄log
✔️ e95418d #6 2023-09-28 23:24:46 ~2 min tests 📄log
✔️ e95418d #7 2023-09-28 23:25:07 ~47 sec tests 📄log
✔️ e95418d #6 2023-09-28 23:26:11 ~3 min android 📦tgz
✔️ e95418d #6 2023-09-28 23:27:03 ~4 min ios 📦tgz
✔️ e95418d #7 2023-09-28 23:27:08 ~4 min ios 📦tgz
✔️ e95418d #7 2023-09-28 23:27:52 ~3 min tests 📄log
✔️ e95418d #7 2023-09-28 23:29:28 ~3 min android 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 89809a0 #8 2023-09-29 04:20:49 ~1 min linux 📦deb
✔️ 89809a0 #8 2023-09-29 04:21:16 ~1 min tests 📄log
✔️ 89809a0 #8 2023-09-29 04:21:35 ~1 min nix-flake 📄log
✔️ 89809a0 #8 2023-09-29 04:21:53 ~2 min tests 📄log
✔️ 89809a0 #8 2023-09-29 04:23:26 ~3 min android 📦tgz
✔️ 89809a0 #8 2023-09-29 04:24:05 ~4 min ios 📦tgz
✔️ da52e4e #9 2023-09-29 05:00:18 ~2 min nix-flake 📄log
✔️ da52e4e #9 2023-09-29 05:00:24 ~2 min tests 📄log
✔️ da52e4e #9 2023-09-29 05:00:33 ~2 min linux 📦deb
✔️ da52e4e #9 2023-09-29 05:01:24 ~3 min tests 📄log
✔️ da52e4e #9 2023-09-29 05:01:58 ~3 min android 📦tgz
✔️ da52e4e #9 2023-09-29 05:02:38 ~4 min ios 📦tgz

@chaitanyaprem chaitanyaprem marked this pull request as ready for review September 26, 2023 09:15
richard-ramos
richard-ramos approved these changes Sep 28, 2023
View reviewed changes
library/c/api_lightpush.go Show resolved Hide resolved
waku/v2/protocol/lightpush/waku_lightpush.go Outdated Show resolved Hide resolved
@chaitanyaprem
Merge branch 'master' into feat/autoshard-lightpush
154287e
@chaitanyaprem
Extract contentFilter and subscriptions out of filter to reuse in rel…
44e8d1f 
…ay (#779)

* chore: extract contentFilter outside filter package

* chore: move subscription outside of filter so that it can be modified and reused for relay
@chaitanyaprem
Merge branch 'master' into feat/autoshard-lightpush
e95418d
@chaitanyaprem chaitanyaprem self-assigned this Sep 28, 2023
@chaitanyaprem chaitanyaprem mentioned this pull request Sep 29, 2023
Open
@chaitanyaprem chaitanyaprem merged commit 47c961d into master Sep 29, 2023
10 of 11 checks passed
@chaitanyaprem chaitanyaprem deleted the feat/autoshard-lightpush branch September 29, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-ramos richard-ramos richard-ramos approved these changes

@harsh-98 harsh-98 Awaiting requested review from harsh-98

Assignees

@chaitanyaprem chaitanyaprem

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaitanyaprem @status-im-auto @richard-ramos